Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't expand objects from unloaded regions in the ObjectInspector #3069

Merged
merged 2 commits into from
Jul 19, 2021
Merged

Don't expand objects from unloaded regions in the ObjectInspector #3069

merged 2 commits into from
Jul 19, 2021

Conversation

hbenl
Copy link
Contributor

@hbenl hbenl commented Jul 14, 2021

No description provided.

@vercel
Copy link

vercel bot commented Jul 14, 2021

@hbenl is attempting to deploy a commit to the recordreplay Team on Vercel.

A member of the Team first needs to authorize it.

@hbenl hbenl linked an issue Jul 14, 2021 that may be closed by this pull request
Don't expand objects from unloaded regions in the ObjectInspector #3039
Closed
@hbenl hbenl requested a review from ryanjduffy July 15, 2021 16:10
@vercel
Copy link

vercel bot commented Jul 16, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/recordreplay/devtools/EaXxeAQCqJfBxGCK1GGnFibE66fz
✅ Preview: https://devtools-git-fork-hbenl-issue-3039-recordreplay.vercel.app

ryanjduffy
ryanjduffy approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@ryanjduffy ryanjduffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work as advertised though I'm curious when it will come into effect once #3067 lands.

@hbenl
Copy link
Contributor Author

hbenl commented Jul 19, 2021

I'm curious when it will come into effect once #3067 lands.

It shouldn't make any difference for the console, but it's still possible (at least in theory) that the region containing the current pause gets unloaded, in that case it would have an effect on the scopes panel. Also, I see it as a safety net in case an object from an unloaded region accidentally "leaks" into the UI.

@hbenl hbenl merged commit 9b82058 into replayio:master Jul 19, 2021
@hbenl hbenl deleted the issue-3039 branch July 19, 2021 08:40
@ryanjduffy
Copy link
Contributor

👍 Thanks for the explanation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanjduffy ryanjduffy ryanjduffy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't expand objects from unloaded regions in the ObjectInspector
2 participants
@hbenl @ryanjduffy