Make the plan detail page dynamic #4654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was definitely a smaller change in here somewhere, but I think this sets us up for some more changes down the road here.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/recordreplay/devtools/5rp4b4Ybtn7WxnfxniDsTo3rY3Vf |
jcmorrow
force-pushed
the
jm-dynamic-pricing
branch
from
d4d6fbb
to
554c5c4
Compare
ryanjduffy
force-pushed
the
jm-dynamic-pricing
branch
from
463cde7
to
37a9b45
Compare
ryanjduffy
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our billing is starting to get more varied. This tries to adapt the PlanDetails page so that it looks more reasonable for Teams, Beta Testers, and Organization Plan folks. It also lays the groundwork for adding annual billing, someday. It also adds storybook stories for this panel, but since the panel isn't contained inside of the settings modal in storybook (and since doing this would involve hashing out all of the Apollo mock stuff) it's of limited use right now (though not useless).
Closes https://github.com/RecordReplay/devtools/issues/4636