Added API for easy switching between cameras #27
Conversation
| @NonNull | ||
| private Fotoapparat fotoapparat; | ||
|
|
||
| private boolean started = false; |
There was a problem hiding this comment.
I like to make things explicit to indicate that I intentionally wanted it to be false. My OCD :)
| * Switches between different instances of {@link Fotoapparat}. Convenient when you want to allow | ||
| * user to switch between different cameras or configurations. | ||
| * <p> | ||
| * This class is not thread safe. Consider using it from a single thread. |
There was a problem hiding this comment.
I am afraid that users will overlook this
There was a problem hiding this comment.
One should always assume that things are not thread safe. This JavaDoc just confirms it.
| } | ||
|
|
||
| private void takePicture() { | ||
| PhotoResult photoResult = fotoapparat.takePicture(); | ||
| PhotoResult photoResult = fotoapparatSwitcher.getCurrentFotoapparat().takePicture(); |
There was a problem hiding this comment.
how about we delegate the FA's actions like takePicture in the FAS?
There was a problem hiding this comment.
Basically this and capabilities and autofocus
There was a problem hiding this comment.
Yeah, I also thought about it, but it would explode the API of Switcher and we'll always have to support it. I suggest we proceed with current API, and then after 1.1, we'll see how big API of Fotoapparat will become. If it won't grow noticeably, then we'll do as you say.
As requested by #20