Make all the configuration objects have nicer toString values #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansman
commented
Feb 21, 2019
|
|
||
| /** | ||
| * The camera can only support a variable zoom level between (and including) 0 and [maxZoom] values. | ||
| * [zoomRatios] is a list of all zoom values. Ratios are in 1/100 increments. For example, zoom of | ||
| * 2.7x is returned as 270. The number of elements is [maxZoom] + 1. List is sorted from small to | ||
| * large. First element is always 100. The last element is the zoom ratio of the maximum zoom value. | ||
| */ | ||
| data class VariableZoom(val maxZoom: Int, val zoomRatios: List<Int>) : Zoom() | ||
| data class VariableZoom(val maxZoom: Int, val zoomRatios: List<Int>) : Zoom() { | ||
| override fun toString(): String = "Zoom.VariableZoom(maxZoom=$maxZoom, zoomRatios=$zoomRatios)" |
There was a problem hiding this comment.
This changes so that it can keep the standard of doing <parent>.<child>, the default data class implementation does not do this.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously doing
Flash.Off.toString()would return something likeio.fotoapparat.parameter.Flash$Off@a486ccc, now it will returnFlash.Off.