Merge python3 into master for CI and Python3 compatibility #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests failed under CI, even though they succeeded on Python 3.6 Ubuntu. The methods were not properly swapped because of the added if-statement.
The coverage reports are not accurate if not all platforms and all environments are considered.
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
=========================================
Coverage ? 91.66%
=========================================
Files ? 2
Lines ? 72
Branches ? 0
=========================================
Hits ? 66
Misses ? 6
Partials ? 0
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Responding to the concerns raised in #5, it seems appropriate to port the library over to Python 3. As I was working on it, I also thought that adding CI would be a good idea.
Note that also various PEP-8 violations were fixed, including those in the naming of the keyword arguments. The keyword arguments are now using
_instead of CamelCase.