Skip to content

Commit

Permalink
Add notes for FIXME
Browse files Browse the repository at this point in the history
  • Loading branch information
Knightly1 committed Jan 6, 2024
1 parent 4bab96f commit 9e4888f
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions MQ2Debuffs.cpp
Expand Up @@ -55,7 +55,7 @@
PreSetup("MQ2Debuff");
PLUGIN_VERSION(2.0);

// FIXME: I suspect most of these are maintained in core.
// FIXME: I suspect most of these are maintained in core. They are also now outdated and incorrect
#define MAXBUFF_WARDER 30
#define MAXBUFF_MYSELF 25

Expand Down Expand Up @@ -316,8 +316,9 @@ class MQ2DebuffType : public MQ2Type {

if(!_stricmp(Index,"pet") || !_stricmp(Index,"warder")) {
if(pPetInfoWnd && GetCharInfo() && GetCharInfo()->pSpawn && GetCharInfo()->pSpawn->PetID>0) {
// FIXME: This would likely be better as a range based for loop
for(int b=0; b<MAXBUFF_WARDER; b++) {
if(PSPELL spell = GetSpellByID(pPetInfoWnd->GetBuff(b)))
if(const PSPELL spell = GetSpellByID(pPetInfoWnd->GetBuff(b)))
if(spell->DurationCap>0) {
((spell->SpellType)?bList[bSize++]:dList[dSize++])=spell;
aList[aSize++]=spell;
Expand Down

0 comments on commit 9e4888f

Please sign in to comment.