Skip to content

Commit

Permalink
fix(tabs): remove color provider from rh-tab-panel (#1376)
Browse files Browse the repository at this point in the history
* fix(tabs): remove color context provider from panels

* chore(tabs): add changeset

* docs: Apply suggestions from code review

---------

Co-authored-by: Benny Powers - עם ישראל חי! <bennypowers@users.noreply.github.com>
  • Loading branch information
zeroedin and bennypowers committed Dec 10, 2023
1 parent 3e1f54b commit 0254749
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
5 changes: 5 additions & 0 deletions .changeset/itchy-dogs-matter.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@rhds/elements": patch
---

`<rh-tab-panel>`: removed unused color-palette attribute
7 changes: 0 additions & 7 deletions elements/rh-tabs/rh-tab-panel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import { classMap } from 'lit/directives/class-map.js';
import { BaseTabPanel } from '@patternfly/elements/pf-tabs/BaseTabPanel.js';

import { colorContextConsumer, type ColorTheme } from '../../lib/context/color/consumer.js';
import { colorContextProvider, type ColorPalette } from '../../lib/context/color/provider.js';

import styles from './rh-tab-panel.css';

Expand All @@ -28,12 +27,6 @@ export class RhTabPanel extends BaseTabPanel {
*/
@colorContextConsumer() private on?: ColorTheme;

/**
* Sets color context for child components, overrides parent context
*/
@colorContextProvider()
@property({ reflect: true, attribute: 'color-palette' }) colorPalette?: ColorPalette;

render() {
const { on = '' } = this;
return html`
Expand Down

0 comments on commit 0254749

Please sign in to comment.