Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(button): update docs #1006

Merged
merged 53 commits into from
Jun 4, 2023
Merged

docs(button): update docs #1006

merged 53 commits into from
Jun 4, 2023

Conversation

nikkimk
Copy link
Collaborator

@nikkimk nikkimk commented May 30, 2023

What I did

  1. Updated button docs [docs] Button docs need review/cleanup #925 .

Testing Instructions

  1. View DP button docs.
  2. Compare to Button doc and to Docs cleanup checklist.

Notes to Reviewers

The following are WIP dependent on other issues/PRs:

@nikkimk nikkimk linked an issue May 30, 2023 that may be closed by this pull request
@changeset-bot
Copy link

changeset-bot bot commented May 30, 2023

🦋 Changeset detected

Latest commit: bc51857

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@rhds/elements Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented May 30, 2023

Deploy Preview for red-hat-design-system ready!

Name Link
🔨 Latest commit bc51857
🔍 Latest deploy log https://app.netlify.com/sites/red-hat-design-system/deploys/647c2f4680ba430008136ede
😎 Deploy Preview https://deploy-preview-1006--red-hat-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Contributor

github-actions bot commented May 30, 2023

Size Change: +92 B (0%)

Total Size: 187 kB

Filename Size Change
./elements/rh-button/rh-button.js 3.77 kB +92 B (+3%)
ℹ️ View Unchanged
Filename Size
./elements/rh-accordion/rh-accordion-header.js 1.98 kB
./elements/rh-accordion/rh-accordion-panel.js 1.24 kB
./elements/rh-accordion/rh-accordion.js 1.15 kB
./elements/rh-alert/rh-alert.js 4.25 kB
./elements/rh-avatar/random-pattern-controller.js 2.72 kB
./elements/rh-avatar/rh-avatar.js 26.6 kB
./elements/rh-badge/rh-badge.js 745 B
./elements/rh-blockquote/rh-blockquote.js 1.96 kB
./elements/rh-card/rh-card.js 1.96 kB
./elements/rh-context-provider/rh-context-provider.js 749 B
./elements/rh-cta/rh-cta.js 3.76 kB
./elements/rh-dialog/rh-dialog.js 1.64 kB
./elements/rh-dialog/yt-api.js 614 B
./elements/rh-footer/rh-footer-block.js 765 B
./elements/rh-footer/rh-footer-copyright.js 362 B
./elements/rh-footer/rh-footer-links.js 1.06 kB
./elements/rh-footer/rh-footer-social-link.js 960 B
./elements/rh-footer/rh-footer-universal.js 4.07 kB
./elements/rh-footer/rh-footer.js 5.04 kB
./elements/rh-footer/rh-global-footer.js 250 B
./elements/rh-navigation-secondary/rh-navigation-secondary-dropdown.js 2.42 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-menu-section.js 1.47 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-menu.js 1.74 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-overlay.js 571 B
./elements/rh-navigation-secondary/rh-navigation-secondary.js 4.82 kB
./elements/rh-navigation-secondary/test/fixtures.js 851 B
./elements/rh-pagination/rh-pagination.js 4.17 kB
./elements/rh-spinner/rh-spinner.js 1.56 kB
./elements/rh-stat/rh-stat.js 2.3 kB
./elements/rh-subnav/rh-subnav.js 2.77 kB
./elements/rh-tabs/rh-tab-panel.js 697 B
./elements/rh-tabs/rh-tab.js 1.45 kB
./elements/rh-tabs/rh-tabs.js 1.61 kB
./elements/rh-tag/rh-tag.js 1.9 kB
./elements/rh-tooltip/rh-tooltip.js 1.16 kB
./lib/context/color/consumer.js 1.15 kB
./lib/context/color/controller.js 1.11 kB
./lib/context/color/provider.js 2 kB
./lib/context/event.js 598 B
./lib/DirController.js 488 B
./lib/functions.js 175 B
./lib/ScreenSizeController.js 856 B
./rhds.min.js 85.4 kB

compressed-size-action

@bennypowers bennypowers changed the title docs(button): Update docs docs(button): update docs Jun 1, 2023
@nikkimk nikkimk marked this pull request as ready for review June 2, 2023 17:54
@coreyvickery
Copy link
Collaborator

@nikkimk Tiny edits:

Overview page

  • Under the Sample component h2, let's go with one Primary button only
  • Repo status table does not reflect the design

Style page

  • Under the Space h2, the word Guidelines should link to the Guidelines tab

Copy link
Collaborator

@coreyvickery coreyvickery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go.

@bennypowers bennypowers enabled auto-merge (squash) June 4, 2023 06:29
@bennypowers bennypowers merged commit 86c606b into main Jun 4, 2023
8 checks passed
@bennypowers bennypowers deleted the docs/button branch June 4, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Button docs need review/cleanup
3 participants