Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix cta and alert shortcodes #1015

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Conversation

bennypowers
Copy link
Member

@bennypowers bennypowers commented Jun 1, 2023

refactors and fixes the cta and alert shortcodes
removes the width attr from example shortcode

What I did

  1. trim whitespace from cta
  2. modularize and refactor shortcodes

Testing Instructions

  1. /elements/call-to-action/
  2. /elements/accordion/

Notes to Reviewers

refactors and fixes the cta and alert shortcodes
removes the `width` attr from example shortcode
@changeset-bot
Copy link

changeset-bot bot commented Jun 1, 2023

⚠️ No Changeset found

Latest commit: ec28bc9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jun 1, 2023

Deploy Preview for red-hat-design-system ready!

Name Link
🔨 Latest commit ec28bc9
🔍 Latest deploy log https://app.netlify.com/sites/red-hat-design-system/deploys/64787301bd8a9b00086efdd2
😎 Deploy Preview https://deploy-preview-1015--red-hat-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

bennypowers added a commit that referenced this pull request Jun 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

Size Change: 0 B

Total Size: 187 kB

ℹ️ View Unchanged
Filename Size
./elements/rh-accordion/rh-accordion-header.js 1.98 kB
./elements/rh-accordion/rh-accordion-panel.js 1.24 kB
./elements/rh-accordion/rh-accordion.js 1.15 kB
./elements/rh-alert/rh-alert.js 4.24 kB
./elements/rh-avatar/random-pattern-controller.js 2.72 kB
./elements/rh-avatar/rh-avatar.js 26.6 kB
./elements/rh-badge/rh-badge.js 745 B
./elements/rh-blockquote/rh-blockquote.js 1.96 kB
./elements/rh-button/rh-button.js 3.67 kB
./elements/rh-card/rh-card.js 1.96 kB
./elements/rh-context-provider/rh-context-provider.js 749 B
./elements/rh-cta/rh-cta.js 3.76 kB
./elements/rh-dialog/rh-dialog.js 1.64 kB
./elements/rh-dialog/yt-api.js 614 B
./elements/rh-footer/rh-footer-block.js 765 B
./elements/rh-footer/rh-footer-copyright.js 362 B
./elements/rh-footer/rh-footer-links.js 1.06 kB
./elements/rh-footer/rh-footer-social-link.js 960 B
./elements/rh-footer/rh-footer-universal.js 4.07 kB
./elements/rh-footer/rh-footer.js 5.04 kB
./elements/rh-footer/rh-global-footer.js 250 B
./elements/rh-navigation-secondary/rh-navigation-secondary-dropdown.js 2.42 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-menu-section.js 1.47 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-menu.js 1.74 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-overlay.js 571 B
./elements/rh-navigation-secondary/rh-navigation-secondary.js 4.83 kB
./elements/rh-navigation-secondary/test/fixtures.js 851 B
./elements/rh-pagination/rh-pagination.js 4.17 kB
./elements/rh-spinner/rh-spinner.js 1.56 kB
./elements/rh-stat/rh-stat.js 2.3 kB
./elements/rh-subnav/rh-subnav.js 2.77 kB
./elements/rh-tabs/rh-tab-panel.js 697 B
./elements/rh-tabs/rh-tab.js 1.45 kB
./elements/rh-tabs/rh-tabs.js 1.61 kB
./elements/rh-tag/rh-tag.js 1.91 kB
./elements/rh-tooltip/rh-tooltip.js 1.14 kB
./lib/context/color/consumer.js 1.15 kB
./lib/context/color/controller.js 1.11 kB
./lib/context/color/provider.js 2 kB
./lib/context/event.js 598 B
./lib/DirController.js 488 B
./lib/functions.js 175 B
./lib/ScreenSizeController.js 856 B
./rhds.min.js 85.4 kB

compressed-size-action

@bennypowers bennypowers added the docs Improvements or additions to documentation label Jun 1, 2023
@bennypowers bennypowers requested a review from eyevana June 1, 2023 10:26
@bennypowers bennypowers enabled auto-merge (squash) June 1, 2023 10:29
@bennypowers bennypowers merged commit 1dcccec into main Jun 1, 2023
8 checks passed
@bennypowers bennypowers deleted the docs/fix-cta-alert-shortcodes branch June 1, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants