Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(accordion): updated docs #1020

Merged
merged 19 commits into from
Jun 5, 2023
Merged

docs(accordion): updated docs #1020

merged 19 commits into from
Jun 5, 2023

Conversation

nikkimk
Copy link
Collaborator

@nikkimk nikkimk commented Jun 1, 2023

What I did

  1. Updated accordion docs per [docs] Accordion docs need cleanup #897 .

Testing Instructions

  1. View DP Accordion docs.
  2. Compare to Accordion doc and to Docs cleanup checklist.

@changeset-bot
Copy link

changeset-bot bot commented Jun 1, 2023

🦋 Changeset detected

Latest commit: 5a1924a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@rhds/elements Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jun 1, 2023

Deploy Preview for red-hat-design-system ready!

Name Link
🔨 Latest commit 5a1924a
🔍 Latest deploy log https://app.netlify.com/sites/red-hat-design-system/deploys/647dd8e2de89cc0008099bcd
😎 Deploy Preview https://deploy-preview-1020--red-hat-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

Size Change: +13 B (0%)

Total Size: 187 kB

Filename Size Change
./elements/rh-accordion/rh-accordion.js 1.17 kB +13 B (+1%)
ℹ️ View Unchanged
Filename Size
./elements/rh-accordion/rh-accordion-header.js 1.98 kB
./elements/rh-accordion/rh-accordion-panel.js 1.24 kB
./elements/rh-alert/rh-alert.js 4.25 kB
./elements/rh-avatar/random-pattern-controller.js 2.72 kB
./elements/rh-avatar/rh-avatar.js 26.6 kB
./elements/rh-badge/rh-badge.js 745 B
./elements/rh-blockquote/rh-blockquote.js 1.96 kB
./elements/rh-button/rh-button.js 3.77 kB
./elements/rh-card/rh-card.js 1.96 kB
./elements/rh-context-provider/rh-context-provider.js 749 B
./elements/rh-cta/rh-cta.js 3.76 kB
./elements/rh-dialog/rh-dialog.js 1.64 kB
./elements/rh-dialog/yt-api.js 614 B
./elements/rh-footer/rh-footer-block.js 765 B
./elements/rh-footer/rh-footer-copyright.js 362 B
./elements/rh-footer/rh-footer-links.js 1.06 kB
./elements/rh-footer/rh-footer-social-link.js 960 B
./elements/rh-footer/rh-footer-universal.js 4.07 kB
./elements/rh-footer/rh-footer.js 5.04 kB
./elements/rh-footer/rh-global-footer.js 250 B
./elements/rh-navigation-secondary/rh-navigation-secondary-dropdown.js 2.42 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-menu-section.js 1.47 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-menu.js 1.74 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-overlay.js 571 B
./elements/rh-navigation-secondary/rh-navigation-secondary.js 4.82 kB
./elements/rh-navigation-secondary/test/fixtures.js 851 B
./elements/rh-pagination/rh-pagination.js 4.17 kB
./elements/rh-spinner/rh-spinner.js 1.56 kB
./elements/rh-stat/rh-stat.js 2.3 kB
./elements/rh-subnav/rh-subnav.js 2.77 kB
./elements/rh-tabs/rh-tab-panel.js 697 B
./elements/rh-tabs/rh-tab.js 1.45 kB
./elements/rh-tabs/rh-tabs.js 1.61 kB
./elements/rh-tag/rh-tag.js 1.9 kB
./elements/rh-tooltip/rh-tooltip.js 1.16 kB
./lib/context/color/consumer.js 1.15 kB
./lib/context/color/controller.js 1.11 kB
./lib/context/color/provider.js 2 kB
./lib/context/event.js 598 B
./lib/DirController.js 488 B
./lib/functions.js 175 B
./lib/ScreenSizeController.js 856 B
./rhds.min.js 85.4 kB

compressed-size-action

@nikkimk nikkimk added this to the Docs IA updates #2 milestone Jun 1, 2023
@nikkimk nikkimk linked an issue Jun 1, 2023 that may be closed by this pull request
@nikkimk nikkimk marked this pull request as ready for review June 2, 2023 17:55
@coreyvickery coreyvickery self-requested a review June 2, 2023 18:09
Copy link
Collaborator

@coreyvickery coreyvickery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@nikkimk nikkimk requested a review from bennypowers June 5, 2023 12:53
@bennypowers bennypowers added the docs Improvements or additions to documentation label Jun 5, 2023
@bennypowers bennypowers merged commit 1a569a2 into main Jun 5, 2023
8 checks passed
@bennypowers bennypowers deleted the docs/accordion-cleanup branch June 5, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Accordion docs need cleanup
4 participants