Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(example-image-no-border): added styles for example image #1024

Merged
merged 2 commits into from
Jun 2, 2023

Conversation

nikkimk
Copy link
Collaborator

@nikkimk nikkimk commented Jun 1, 2023

What I did

  1. Modified example SCSS for docs for an example image with no palette, or "none" as described in [feat] example image no border for docs #1023 .
  2. Added "none" option in example shortcode documentation for palette.

Testing Instructions

  1. Go to the first image under Sizes heading on Spinner's Guidelines page .
  2. Image should have no padding.
  3. Image should have no border.
  4. Image should have no background.
  5. Image should should be responsive.

Notes to Reviewers

Style should be similar what it currently looks like on ux.redhat.com but possibly less blurry.

@nikkimk nikkimk linked an issue Jun 1, 2023 that may be closed by this pull request
@changeset-bot
Copy link

changeset-bot bot commented Jun 1, 2023

⚠️ No Changeset found

Latest commit: 709b56e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jun 1, 2023

Deploy Preview for red-hat-design-system ready!

Name Link
🔨 Latest commit 709b56e
🔍 Latest deploy log https://app.netlify.com/sites/red-hat-design-system/deploys/647a2ad93547e00008a0949b
😎 Deploy Preview https://deploy-preview-1024--red-hat-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nikkimk nikkimk changed the title feat(example-image-no-border): added styles for an unpadded image wit… feat(example-image-no-border): added styles for example image Jun 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

Size Change: 0 B

Total Size: 187 kB

ℹ️ View Unchanged
Filename Size
./elements/rh-accordion/rh-accordion-header.js 1.98 kB
./elements/rh-accordion/rh-accordion-panel.js 1.24 kB
./elements/rh-accordion/rh-accordion.js 1.15 kB
./elements/rh-alert/rh-alert.js 4.25 kB
./elements/rh-avatar/random-pattern-controller.js 2.72 kB
./elements/rh-avatar/rh-avatar.js 26.6 kB
./elements/rh-badge/rh-badge.js 745 B
./elements/rh-blockquote/rh-blockquote.js 1.96 kB
./elements/rh-button/rh-button.js 3.67 kB
./elements/rh-card/rh-card.js 1.96 kB
./elements/rh-context-provider/rh-context-provider.js 749 B
./elements/rh-cta/rh-cta.js 3.76 kB
./elements/rh-dialog/rh-dialog.js 1.64 kB
./elements/rh-dialog/yt-api.js 614 B
./elements/rh-footer/rh-footer-block.js 765 B
./elements/rh-footer/rh-footer-copyright.js 362 B
./elements/rh-footer/rh-footer-links.js 1.06 kB
./elements/rh-footer/rh-footer-social-link.js 960 B
./elements/rh-footer/rh-footer-universal.js 4.07 kB
./elements/rh-footer/rh-footer.js 5.04 kB
./elements/rh-footer/rh-global-footer.js 250 B
./elements/rh-navigation-secondary/rh-navigation-secondary-dropdown.js 2.42 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-menu-section.js 1.47 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-menu.js 1.74 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-overlay.js 571 B
./elements/rh-navigation-secondary/rh-navigation-secondary.js 4.82 kB
./elements/rh-navigation-secondary/test/fixtures.js 851 B
./elements/rh-pagination/rh-pagination.js 4.17 kB
./elements/rh-spinner/rh-spinner.js 1.56 kB
./elements/rh-stat/rh-stat.js 2.3 kB
./elements/rh-subnav/rh-subnav.js 2.77 kB
./elements/rh-tabs/rh-tab-panel.js 697 B
./elements/rh-tabs/rh-tab.js 1.45 kB
./elements/rh-tabs/rh-tabs.js 1.61 kB
./elements/rh-tag/rh-tag.js 1.9 kB
./elements/rh-tooltip/rh-tooltip.js 1.14 kB
./lib/context/color/consumer.js 1.15 kB
./lib/context/color/controller.js 1.11 kB
./lib/context/color/provider.js 2 kB
./lib/context/event.js 598 B
./lib/DirController.js 488 B
./lib/functions.js 175 B
./lib/ScreenSizeController.js 856 B
./rhds.min.js 85.4 kB

compressed-size-action

@nikkimk nikkimk marked this pull request as ready for review June 1, 2023 22:31
@bennypowers bennypowers changed the title feat(example-image-no-border): added styles for example image docs(example-image-no-border): added styles for example image Jun 2, 2023
Copy link
Collaborator

@zeroedin zeroedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com>
@zeroedin zeroedin merged commit c7c9763 into main Jun 2, 2023
8 checks passed
@zeroedin zeroedin deleted the docs/example-image-no-border branch June 2, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] example image no border for docs
2 participants