Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(accordion): roving tabindex for nested accordions #1053

Merged
merged 3 commits into from
Jun 8, 2023

Conversation

zeroedin
Copy link
Collaborator

@zeroedin zeroedin commented Jun 8, 2023

What I did

  1. Updated dependency on @patternfly/elements for BaseAccordion updates on RTI in nested accordions

Testing Instructions

  1. View deploy preview

Notes to Reviewers

@changeset-bot
Copy link

changeset-bot bot commented Jun 8, 2023

🦋 Changeset detected

Latest commit: 03579db

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@rhds/elements Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jun 8, 2023

Deploy Preview for red-hat-design-system ready!

Name Link
🔨 Latest commit 03579db
🔍 Latest deploy log https://app.netlify.com/sites/red-hat-design-system/deploys/6481efda1c99ad00089e2803
😎 Deploy Preview https://deploy-preview-1053--red-hat-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

Size Change: +116 B (0%)

Total Size: 190 kB

Filename Size Change
./rhds.min.js 85.8 kB +116 B (0%)
ℹ️ View Unchanged
Filename Size
./elements/rh-accordion/rh-accordion-header.js 1.98 kB
./elements/rh-accordion/rh-accordion-panel.js 1.24 kB
./elements/rh-accordion/rh-accordion.js 1.17 kB
./elements/rh-alert/rh-alert.js 4.26 kB
./elements/rh-avatar/random-pattern-controller.js 2.72 kB
./elements/rh-avatar/rh-avatar.js 26.7 kB
./elements/rh-badge/rh-badge.js 922 B
./elements/rh-blockquote/rh-blockquote.js 1.96 kB
./elements/rh-button/rh-button.js 3.77 kB
./elements/rh-card/rh-card.js 1.96 kB
./elements/rh-context-provider/rh-context-provider.js 185 B
./elements/rh-cta/rh-cta.js 3.75 kB
./elements/rh-dialog/rh-dialog.js 1.66 kB
./elements/rh-dialog/yt-api.js 614 B
./elements/rh-footer/rh-footer-block.js 765 B
./elements/rh-footer/rh-footer-copyright.js 362 B
./elements/rh-footer/rh-footer-links.js 1.06 kB
./elements/rh-footer/rh-footer-social-link.js 960 B
./elements/rh-footer/rh-footer-universal.js 4.07 kB
./elements/rh-footer/rh-footer.js 5.07 kB
./elements/rh-footer/rh-global-footer.js 250 B
./elements/rh-navigation-secondary/rh-navigation-secondary-dropdown.js 2.42 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-menu-section.js 1.47 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-menu.js 1.74 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-overlay.js 571 B
./elements/rh-navigation-secondary/rh-navigation-secondary.js 4.84 kB
./elements/rh-navigation-secondary/test/fixtures.js 851 B
./elements/rh-pagination/rh-pagination.js 4.46 kB
./elements/rh-spinner/rh-spinner.js 1.6 kB
./elements/rh-stat/rh-stat.js 2.31 kB
./elements/rh-subnav/rh-subnav.js 2.87 kB
./elements/rh-tabs/rh-tab-panel.js 804 B
./elements/rh-tabs/rh-tab.js 1.88 kB
./elements/rh-tabs/rh-tabs.js 1.92 kB
./elements/rh-tag/rh-tag.js 1.89 kB
./elements/rh-tooltip/rh-tooltip.js 1.16 kB
./lib/context/color/consumer.js 1.15 kB
./lib/context/color/controller.js 1.11 kB
./lib/context/color/provider.js 2 kB
./lib/context/event.js 598 B
./lib/DirController.js 488 B
./lib/elements/rh-context-picker/rh-context-picker.js 1.16 kB
./lib/elements/rh-context-provider/rh-context-provider.js 746 B
./lib/functions.js 175 B
./lib/ScreenSizeController.js 856 B

compressed-size-action

@zeroedin zeroedin requested a review from bennypowers June 8, 2023 15:11
@zeroedin zeroedin self-assigned this Jun 8, 2023
@zeroedin zeroedin added the bug Something isn't working label Jun 8, 2023
@zeroedin zeroedin added this to the RHDS Bellsprout milestone Jun 8, 2023
@zeroedin zeroedin changed the title fix(accordion): fix roving tabindex for nested accordions fix(accordion): roving tabindex for nested accordions Jun 8, 2023
@zeroedin zeroedin enabled auto-merge (squash) June 8, 2023 15:14
@zeroedin zeroedin merged commit 04573fa into main Jun 8, 2023
9 checks passed
@zeroedin zeroedin deleted the fix/accordion/base-rti-update branch June 8, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done ☑️
Development

Successfully merging this pull request may close these issues.

None yet

2 participants