This repository has been archived by the owner on Aug 28, 2023. It is now read-only.
Add modal for uploading/resetting manifest in UI #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzazrivec
reviewed
Jan 27, 2020
| // If JSON.parse fails or the error above is thrown | ||
| dispatch({ | ||
| type: `${CHANGE_MANIFEST}_REJECTED`, | ||
| payload: { data: { error: { message: 'Selected file is not a valid manifest' } } } |
There was a problem hiding this comment.
I think that the Selected file is not a valid manifest string should be enclosed in gettext as well.
|
Checked commits mturley/cfme-migration_analytics@3492260~...640aae8 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
mzazrivec
approved these changes
Jan 28, 2020
simaishi
pushed a commit
that referenced
this pull request
Feb 21, 2020
Add modal for uploading/resetting manifest in UI (cherry picked from commit bc44a72) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1805817
|
Ivanchuk backport details: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1788729
https://issues.redhat.com/browse/MIGENG-242
Closes #27.
Needs to be backported after #28.
Needs unit tests, but otherwise ready for review
Screens
The manifest version display in the lower-right now has an "Update" link next to it:
When clicked, this modal appears:
Clicking the Upload button opens the file browse dialog (and a user can also just drag-and-drop a file onto the modal), then the modal closes and the following spinner appears in place of the version for a moment:
If there is a failure (invalid file or API error), a message is displayed under the version:
If a user-uploaded manifest is present, the Restore button in the modal will be enabled:
Clicking the Restore button will also close the modal immediately and bring up the same spinner while the manifest is being reset to default.