Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail fast on dependencies env option #458

Merged
merged 4 commits into from
Jun 25, 2024

Conversation

justinorringer
Copy link
Contributor

Adding a fail fast variable. In ephemeral, if we set it to false it should help those dependency issues.

Defaulting the value to true in the clowdapp, so we shouldn't have to add the value to app-interface for stage and prod.

Copy link
Contributor

@jrwho jrwho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to deploy this and verify that vulnerability engine, as an optional-dep, was not deployed and VA was able to successfully run.

Bonfire config..

 (iqe-astro-va-plugin) jarice:~>cat .config/bonfire/config.yaml
---

apps:
- name: virtual-assistant
  components:
    - name: virtual-assistant
      host: local
      repo: ~/git/justin_astro_va
      path: /deploy/clowdapp.yaml
      parameters:
        IMAGE_TAG: pr-458-latest

Ran iqe deployment with...

iqe tools test -t test_VA_dialogue --ref-env insights-stage -UD astro_va --deploy_args "--no-release-on-fail --no-remove-resources virtual-assistant --timeout=3000 --optional-deps-method none"

And this in deploy/clowdapp.yaml...

    dependencies:
      - advisor-backend
      - notifications-gw
      - notifications-backend
      - content-sources-backend
      - sources-api
      - rhsm-api-proxy
      - ccx-smart-proxy
      - chrome-service
      - rbac
    optionalDependencies:
      - vulnerability-engine

common/config/app.py Outdated Show resolved Hide resolved
Copy link
Member

@tahmidefaz tahmidefaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! 👍

@justinorringer justinorringer merged commit bb3f04d into RedHatInsights:main Jun 25, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants