Add prometheus hostname to clowdenv status field #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow an entity to look at clowdenv.status.prometheus.hostname to know how to connect to the Prometheus instance associated with this environment. When in app-interface mode, the hostname will just be copied over from clowdenv.spec.providers.metrics.prometheus.appInterfaceHostname. When in operator mode, the hostname will be generated based on the target namespace of the clowdenv. More fields may be added to clowdenv.status.prometheus down the road, e.g. TLS, credentials, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow an entity to look at clowdenv.status.prometheus.hostname
to know how to connect to the Prometheus instance associated with this
environment.
When in app-interface mode, the hostname will just be copied over from
clowdenv.spec.providers.metrics.prometheus.appInterfaceHostname. When in
operator mode, the hostname will be generated based on the target
namespace of the clowdenv.
More fields may be added to clowdenv.status.prometheus down the road,
e.g. TLS, credentials, etc.