Support for multiple kafka brokers #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Mitchell <cmitchel@redhat.com>
gburges
reviewed
Oct 25, 2023
|
/retest |
Signed-off-by: Chris Mitchell <cmitchel@redhat.com>
|
/retest |
Signed-off-by: Chris Mitchell <cmitchel@redhat.com>
|
/retest |
bsquizz
approved these changes
Nov 7, 2023
bsquizz
changed the title
|
Sup! When can we expected to see a new release with this? |
|
This was released to stage last Friday (but we haven't tagged a new official release on github yet) |
|
Ok let us know when we can actually start upgrading dependencies and trying it out on stage. Thanks. |
|
Which dependencies do you need to upgrade? I would expect that you actually should not need to change dependencies because the cdappconfig schema did not change. Clowder is sending 3 broker configurations to apps in stage already. |
|
Oh I thought a clowder bump is needed, disregard then. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a
hostnameskey to be defined in the managed kafka secret as a comma,separated,list of broker hostnames. If it is defined, the cdappconfig's BrokerConfig array will contain all the possible broker hostnames that a client can connect to.If the
hostnameskey is not found, then we fall back to looking for thehostnamekey as we have always done and only have a single BrokerConfig in the array.