Clowdapp Dependency metrics #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamrdrew
reviewed
Feb 21, 2024
There was a problem hiding this comment.
Looks good. I'd approve as-is, but I do have some minor suggestions for improving readability, reducing waste, and being a bit more idiomatic. Sending this back to give you the decision to refactor or not. It's good as it, but there is minor room for improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://issues.redhat.com/browse/RHCLOUD-30912
This adds a new metric, clowder_dependency_availability, that reports the availability of each clowdapp's clowdapp dependencies + optional dependencies. 1 being UP and 0 being DOWN.
This metric gets recorded during ClowdApp reconciliation.