feat(clowdapp): add sessionAffinity support for PublicWebService #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new boolean field in the PublicWebService struct of the ClowdApp CRD. When set to true, this enables session affinity (ClientIP) for the corresponding Kubernetes service, ensuring that requests from the same client are routed to the same pod.
Uh weird flex but alright |
|
/retest |
1 similar comment
|
/retest |
|
UGH What is this? |
|
/retest |
1 similar comment
|
/retest |
Yeah I suggest we just review and merge this. |
psav
requested changes
Mar 14, 2024
tests/kuttl/test-public-webservice-sessionaffinity/03-delete.yaml
Outdated
Show resolved
Hide resolved
|
/retest |
1 similar comment
|
/retest |
|
Can we switch back to the old PR check system? |
|
/retest |
|
Konflux failure appear to be random. There's no consistency to them. At this point my confidence in the clowder PR checks is shaken. I'd like to request we merge this based on human review. |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new boolean field in the PublicWebService struct of the ClowdApp CRD. When set to true, this enables session affinity (ClientIP) for the corresponding Kubernetes service, ensuring that requests from the same client are routed to the same pod.