Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change path in esm scss exports #1228

Closed
wants to merge 1 commit into from

Conversation

rvsia
Copy link
Contributor

@rvsia rvsia commented Aug 5, 2021

This changes the wrong export './index.scss' to correct export { default as style } from "../../RuleTable/./index.css";

But I am not sure if this is what we want as it still throws a warning:

WARNING in ../rule-components/esm/RuleTable/RuleTable.js 40:0-63
export 'default' (reexported as 'style') was not found in '../../RuleTable/./index.css' (module has no exports)

@codecov-commenter
Copy link

Codecov Report

Merging #1228 (6d3c19c) into master (0bcffa3) will not change coverage.
The diff coverage is n/a.

❗ Current head 6d3c19c differs from pull request most recent head 68f5ab6. Consider uploading reports for the commit 68f5ab6 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1228   +/-   ##
=======================================
  Coverage   68.00%   68.00%           
=======================================
  Files         262      262           
  Lines        5091     5091           
  Branches     1785     1785           
=======================================
  Hits         3462     3462           
  Misses       1443     1443           
  Partials      186      186           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bcffa3...68f5ab6. Read the comment docs.

@rvsia
Copy link
Contributor Author

rvsia commented Aug 23, 2021

Closing in favor of #1246

@rvsia rvsia closed this Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants