Update inventory to patternfly-v4 #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karelhala
force-pushed
the
inventory-update-pf4
branch
from
77d7b8f
to
c072532
Compare
rvsia
reviewed
Jun 17, 2020
packages/inventory/src/Inventory.js
Outdated
| @@ -12,6 +12,8 @@ import { Provider } from 'react-redux'; | |||
| import TagWithDialog from './TagWithDialog'; | |||
| export const InventoryContext = createContext('inventory'); | |||
|
|
|||
| console.log(React, 'Inventory version!'); | |||
karelhala
force-pushed
the
inventory-update-pf4
branch
from
c072532
to
89e05bb
Compare
karelhala
force-pushed
the
inventory-update-pf4
branch
from
89e05bb
to
aa94f22
Compare
Hyperkid123
reviewed
Jun 17, 2020
| } | ||
|
|
||
| &:not(.ins-c-inventory__table--toolbar-has-items) { | ||
| .pf-c-data-toolbar__content { |
There was a problem hiding this comment.
The data toolbar component no longer exists. These classNames should change to the toolbar.
There was a problem hiding this comment.
Huh, I thought I already fixed them...
Hyperkid123
reviewed
Jun 17, 2020
| @@ -1,7 +1,6 @@ | |||
| module.exports = { | |||
| externals: [ | |||
| /^@patternfly\/.*/, | |||
| /^@redhat-cloud-services\/.*/, | |||
karelhala
force-pushed
the
inventory-update-pf4
branch
from
32d3c95
to
bdda585
Compare
karelhala
force-pushed
the
inventory-update-pf4
branch
from
b75b4f7
to
2540d0f
Compare
karelhala
added a commit
to karelhala/frontend-components
that referenced
this pull request
Jun 23, 2020
* Update inventory to patternfly-v4 * Remove data toolbar selectors * Wrap a-href element to div
karelhala
added a commit
that referenced
this pull request
Jun 23, 2020
* Update components pf4 (#558) * updated utils to PFv4 * Update PF dependencies versions * Upgrade components to PF4v4 * Update notifications to PF4v4 * Update source to PF4 v4 * Update rule components to PF4v4 (#565) * Update FEC remediations to PF4 * Update pdf generator PF dependencies (#566) * Change version to 2.1.0-beta * Updates css class from .pf-c-data-toolbar__item to .pf-c-toolbar__item primary-toolbar.scss DataToolbar was renamed to Toolbar, and the related css classes too * Update inventory to patternfly-v4 (#575) * Update inventory to patternfly-v4 * Remove data toolbar selectors * Wrap a-href element to div * Update general info to PF version 4 (#576) * Copy indexes after components are built (#579) * Upgrade PF of inventory insights to newest version * Upgrade inventory-compliance to Patternfly v4 (#574) * Final test updates to properly link packages (#582) Co-authored-by: Martin Maroši <marvusm.mmi@gmail.com> Co-authored-by: Richard Vsiansky <r.vsia@seznam.cz> Co-authored-by: PanSpagetka <rknaur@redhat.com> Co-authored-by: Josejulio Martínez <jmartine@redhat.com> Co-authored-by: Sebastian Gräßl <bastilian@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.