Minor issues with error messages

[Fryguy]

Was reviewing some API things with @psav and we noticed a few minor oddities:

1. When you pass invalid fields (readonly for example) in a POST request, the error string that comes back has the values as symbols. However this is strange from non-Ruby clients where symbols aren't a thing (nor or they even a thing in JSON). These should be changed in the error message to just strings.

2. If a null value is passed to a non-nullable field the error message is strange. Something like a, b, c: don't accept null

cc @bdunne

[bdunne]

Do you have examples? We have a bunch of test cases for these responses. Are we missing some?

[Fryguy]

Some of them are there -

• symbols example - https://github.com/ManageIQ/sources-api/blob/42b6081347b45958898121f39197007b8b1d23ad/spec/requests/api/v1.0/sources_spec.rb#L204

• Bad grammar (singular item with "are") - https://github.com/ManageIQ/sources-api/blob/42b6081347b45958898121f39197007b8b1d23ad/spec/requests/api/v1.0/sources_spec.rb#L64

• Bad grammer ("xxx isn't match") https://github.com/ManageIQ/sources-api/blob/42b6081347b45958898121f39197007b8b1d23ad/spec/requests/api/v1.0/sources_spec.rb#L84

• Strange grammer - https://github.com/ManageIQ/sources-api/blob/42b6081347b45958898121f39197007b8b1d23ad/spec/requests/api/v1.0/sources_spec.rb#L214

[mkanoor]

The bad grammar issue is coming from the openapi parser They are all listed here https://github.com/ota42y/openapi_parser/blob/master/lib/openapi_parser/errors.rb Look for the message method

…

On Wed, Oct 9, 2019 at 11:34 AM Jason Frey ***@***.***> wrote: Some of them are there - - symbols example - https://github.com/ManageIQ/sources-api/blob/42b6081347b45958898121f39197007b8b1d23ad/spec/requests/api/v1.0/sources_spec.rb#L204 - Bad grammar (singular item with "are") - https://github.com/ManageIQ/sources-api/blob/42b6081347b45958898121f39197007b8b1d23ad/spec/requests/api/v1.0/sources_spec.rb#L64 - Bad grammer ("xxx isn't match") https://github.com/ManageIQ/sources-api/blob/42b6081347b45958898121f39197007b8b1d23ad/spec/requests/api/v1.0/sources_spec.rb#L84 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#121>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABRHLW64HVSH4JM2ZZIVGETQNX2X7ANCNFSM4I7AMWTA> .

[bdunne]

Opened a PR to the library that raises these errors... ota42y/openapi_parser#55

[Fryguy]

@bdunne Can this be closed now?