Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openapi-validator.sh script for reference from API repos. #202

Merged

Conversation

gmcculloug
Copy link
Contributor

Part of fixing #201

Move the openapi-validator.sh script to a common location for all the API repos to access.

@dippy-bot
Copy link

Checked commit gmcculloug@cce78be with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@lindgrenj6
Copy link
Contributor

I think we need to add .travis_scripts/ to the gemspec here:

spec.files = Dir["{app,config,db,lib,spec/support}/**/*", "LICENSE.txt", "Rakefile", "README.md"]

Looking at it now it doesn't look like it's included. Of course this all depends if we decide to download it from github or use the version bundled with the gem.

@gmcculloug
Copy link
Contributor Author

@lindgrenj6 Good point. I did end up switching to downloading the script from the master branch so we probably can avoid adding it to the gem unless others thing it should be there for some reason. For now, I'll leave the PR as-is and can update if there is more feedback on this topic.

Copy link
Contributor

@lindgrenj6 lindgrenj6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if we do need to include this in the gem later we need to just update the .gemspec to include .travis_scripts/.

@lindgrenj6 lindgrenj6 merged commit f2d789b into RedHatInsights:master Jun 29, 2020
@gmcculloug gmcculloug deleted the openapi-validator_script branch July 10, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants