-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add download of openapi-generator script #204
Conversation
@@ -2,6 +2,9 @@ | |||
set -eu | |||
set -o pipefail | |||
|
|||
curl -L https://raw.githubusercontent.com/OpenAPITools/openapi-generator/master/bin/utils/openapi-generator-cli.sh > ./openapi-generator-cli | |||
chmod +x ./openapi-generator-cli | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we add an echo
here to indicate the curl download is completed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bzwei Added an echo
. Is that what you were looking for?
8192a2e
to
b9a6e4e
Compare
Checked commit b9a6e4e with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.35.0, and yamllint |
@gmcculloug does this need a new gem release? or is this script just downloaded from master in the child-repos? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@lindgrenj6 No, the callers pull this file directly from the master branch during the travis test run. Example: https://github.com/RedHatInsights/sources-api/pull/244/files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gmcculloug cool, LGTM then!
After spending some time with other travis scripts I started thinking it would be better to move the download of
openapi-generator-cli
to this common method instead of requiring each caller to have to download it separately as part of the.travis.yaml
It's not a big impact here (2 new lines), but the caller's
.travis.yml
file can be reduced to one line:If you like this approach it can be merged ahead of updating the callers to use the 1-line call.