Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure Pundit exception's query type is String #205

Merged
merged 2 commits into from
Jul 28, 2020
Merged

Make sure Pundit exception's query type is String #205

merged 2 commits into from
Jul 28, 2020

Conversation

hsong-rh
Copy link
Contributor

This PR allows authorize to accept symbol as its second parameter, like authorized(Portfolio, :update?), otherwise following delete_suffix will fail and raise other exceptions.

@hsong-rh hsong-rh requested review from eclarizio and bzwei July 27, 2020 16:20
eclarizio
eclarizio suggested changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@eclarizio eclarizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry, actually I missed the spec, can you change the spec to use a symbol to prove this change is needed?

eclarizio
eclarizio reviewed Jul 28, 2020
View reviewed changes
Copy link
Contributor

@eclarizio eclarizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small question, curious on your thoughts.

spec/lib/insights/api/common/custom_exceptions_spec.rb Outdated Show resolved Hide resolved
eclarizio
eclarizio approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@eclarizio eclarizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

syncrou
syncrou approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@syncrou syncrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bzwei bzwei merged commit 9a9e094 into RedHatInsights:master Jul 28, 2020
@hsong-rh hsong-rh deleted the change_exception_query branch July 28, 2020 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eclarizio eclarizio eclarizio approved these changes

@syncrou syncrou syncrou approved these changes

@bzwei bzwei bzwei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hsong-rh @eclarizio @syncrou @bzwei