Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow applications to get user information from JWT #48

Merged
merged 2 commits into from
Oct 16, 2018
Merged

Allow applications to get user information from JWT #48

merged 2 commits into from
Oct 16, 2018

Conversation

karelhala
Copy link
Contributor

No description provided.

@iphands
Copy link
Contributor

iphands commented Oct 12, 2018

@karelhala I dont think this is gonna work. I think we have a bad chance of a race happening with this.
We need should wrap this function in something promise based that waits for Jwt.onInit Jwt.isAuthenticated or onInitialUpdateToken I think.

Do you agree?

@karelhala
Copy link
Contributor Author

@iphands good point, I'll wrap it up.

@ryelo ryelo mentioned this pull request Oct 15, 2018
Closed
@karelhala karelhala merged commit 1776ac9 into RedHatInsights:master Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryelo ryelo ryelo approved these changes

@iphands iphands Awaiting requested review from iphands

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@karelhala @iphands @ryelo