enhance and fix for softnet_data parser #3561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enhance and fix for softnet_data parser * the offset for cpu_collision, received_rps, flow_limit_count was not correct * torvalds/linux@7d58e65 introduce two new columns, softnet_backlog_len and index * the code example in the note was wrong, is_packet_drops is a proprety not a function * additional documentation and links about softnet_data structure and history * additional unit tests
xiangce
requested changes
Oct 21, 2022
There was a problem hiding this comment.
Hey @remijouannet, Thank you very much for contributing to insights-core. Besides the following comments, Could you please also fix the flake8 errors to make the pipeline pass?
Please check the flake8 errors here
Thanks.
Signed-off-by: remi <remijouannet@gmail.com>
Signed-off-by: remi <remijouannet@gmail.com>
ryan-blakley
requested changes
Oct 21, 2022
…when does not exist Signed-off-by: remi <remijouannet@gmail.com>
Signed-off-by: remi <remijouannet@gmail.com>
Signed-off-by: remi <remijouannet@gmail.com>
Signed-off-by: remi <remijouannet@gmail.com>
xiangce
approved these changes
Oct 27, 2022
xiangce
pushed a commit
that referenced
this pull request
Oct 27, 2022
* Signed-off-by: remi <remijouannet@gmail.com> enhance and fix for softnet_data parser * the offset for cpu_collision, received_rps, flow_limit_count was not correct * torvalds/linux@7d58e65 introduce two new columns, softnet_backlog_len and index * the code example in the note was wrong, is_packet_drops is a proprety not a function * additional documentation and links about softnet_data structure and history * additional unit tests * fix flake8 and docstring Signed-off-by: remi <remijouannet@gmail.com> * removed linux block of docstring Signed-off-by: remi <remijouannet@gmail.com> * fix doc string, deal with 9,10,11,13 columns, show None instead of 0 when does not exist Signed-off-by: remi <remijouannet@gmail.com> * less 0 in softnet_test Signed-off-by: remi <remijouannet@gmail.com> * fix E222 error Signed-off-by: remi <remijouannet@gmail.com> * add doctest to test_softnet_stat.py Signed-off-by: remi <remijouannet@gmail.com> (cherry picked from commit 88f32d2)
remijouannet
added a commit
to remijouannet/procfs
that referenced
this pull request
Nov 4, 2022
…ort for 9,10,11 and 13 columns, unitest has also more case
remijouannet
added a commit
to remijouannet/procfs
that referenced
this pull request
Nov 7, 2022
…ort for 9,10,11 and 13 columns, unitest has also more case Signed-off-by: remi <remijouannet@gmail.com>
SuperQ
pushed a commit
to prometheus/procfs
that referenced
this pull request
Dec 18, 2022
* handle more column from softnet_data
* add CPUCollision for linux 2.6
* add ReceivedRps and FlowLimitCount for linux >4.17
* add SoftnetBacklogLen and Index for linux 5.10 torvalds/linux@7d58e65
* add Width so anyone can choose to use Index instead of line index, see
* the commit torvalds/linux@7d58e65
* following the merge of RedHatInsights/insights-core#3561, adding support for 9,10,11 and 13 columns, unitest has also more case
Signed-off-by: remi <remijouannet@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
enhance and fix for softnet_data parser
torvalds/linux@7d58e65 introduce two new columns, softnet_backlog_len and index
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
Add your description here