[Draft] feat: Handle malware sources with many matches #3889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhuth
force-pushed
the
handle_many_matches
branch
from
99a8ec1
to
0c28a00
Compare
mhuth
changed the title
mhuth
changed the title
mhuth
force-pushed
the
handle_many_matches
branch
from
0c28a00
to
ed7057f
Compare
Signed-off-by: Mark Huth <mhuth@redhat.com>
mhuth
force-pushed
the
handle_many_matches
branch
from
ed7057f
to
147573f
Compare
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Pull Requests:
Check all that apply:
Part enhancement but mostly corrects an issue. If a source has many rule matches then its possible its a rogue rules file, ie its not in the usual location we download it to. In that case we ignore its matches so its not reported back to the backend. Hmm, or perhaps we want to keep this so there is a record of rogue rules files 馃 ...