refactor: remove legacy collection

[xiangce]

• and remove all dependent codes and relevant tests
• see RHINENG-6982

All Pull Requests:

Check all that apply:

• Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
• Is this PR to correct an issue?
• Is this PR an enhancement?

Complete Description of Additions/Changes:

Add your description here

[xiangce]

This PR requires corresponding modifications to the IQE test. Before this, the IQE test will always fail.

[m-horky]

So, how does this work with RHEL 6, which was shipped with Client 3.0.14?

[xiangce]

For RHEL 6, or RHEL 7, any client installed with a version older than 3.0.14, core_collect will be set to True by default, after this change.

[xiangce]

Per my test, the oldest version of the insights-client insights-client-3.0.0-4 that we provided to the customers, works well with core_collect=True on RHEL 6/7, for details please check the new comment to the RHINENG-6982

[candlepin-bot]

Can one of the admins verify this patch?

[JoySnow]

Hi @xiangce , the legacy collection change looks good to me. And I tried to run cli command insights-collect, it broken into an circular import error related to circular import, while this command works fine with the code in master branch.

FYI, the detail command output example:

$ insights-collect --help
Traceback (most recent call last):
  File "/root/Work/insights-core/venv39/bin/insights-collect", line 33, in <module>
    sys.exit(load_entry_point('insights-core', 'console_scripts', 'insights-collect')())
  File "/root/Work/insights-core/venv39/bin/insights-collect", line 25, in importlib_load_entry_point
    return next(matches).load()
  File "/usr/lib64/python3.9/importlib/metadata.py", line 86, in load
    module = import_module(match.group('module'))
  File "/usr/lib64/python3.9/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 850, in exec_module
  File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
  File "/root/Work/insights-core/insights/collect.py", line 23, in <module>
    from insights.core.spec_cleaner import Cleaner
  File "/root/Work/insights-core/insights/core/spec_cleaner.py", line 24, in <module>
    from insights.client.constants import InsightsConstants as constants
  File "/root/Work/insights-core/insights/client/__init__.py", line 14, in <module>
    from . import client
  File "/root/Work/insights-core/insights/client/client.py", line 22, in <module>
    from .connection import InsightsConnection
  File "/root/Work/insights-core/insights/client/connection.py", line 39, in <module>
    from insights.core.spec_cleaner import Cleaner
ImportError: cannot import name 'Cleaner' from partially initialized module 'insights.core.spec_cleaner' (most likely due to a circular import) (/root/Work/insights-core/insights/core/spec_cleaner.py)

[xiangce]

Hi @JoySnow - thanks for reviewing. The issue you found was fixed in the latest commit, please have a look again.

[m-horky]

I've been able to run this Core on RHEL 6.10 system with Client 3.0.14. I don't think I have notes.

[JoySnow]

Thanks for the update @xiangce . The insights-collect command works well now.

$ insights-collect 
/tmp/insights-xiaoxwan-test321-rhel91.default-20240521082408