Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: collect image builder's osbuild.facts #4119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

croissanne
Copy link

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

#3848 added an image builder fact to the
subscription_manage parser, but there are multiple facts present in
osbuild.facts. Just expose all of them.

RedHatInsights#3848 added an image builder fact to the
subscription_manage parser, but there are multiple facts present in
osbuild.facts. Just expose all of them.

Signed-off-by: Sanne Raymaekers <sanne.raymaekers@gmail.com>
@xiangce
Copy link
Contributor

xiangce commented Jun 13, 2024

Hello, @croissanne - May I know more context about adding this Specs, e.g., is it for analysis purpose or any other Insights Services? Today, for new specs to be collected, we manage them with the RHINENG JIRA board. Would you mind opening an RHINENG card in Jira with component = Insights Specs to get it approved before merging this PR merged?

@croissanne
Copy link
Author

@xiangce Sure, opened https://issues.redhat.com/browse/RHINENG-10848, forgot to set the component however and I can't edit tickets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants