fix: Serialize playbooks manually on Python 3.12+ #4120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failure in Python 2.7 run is caused by a race condition and it a long-running issue. It should be mitigated by #4121. |
* Card ID: CCT-538 The playbook verification relies signatures created from hashes of serialized snippets/playbooks. Python 3.12 changed the way it serializes OrderedDict objects into strings, making the verification fail, resulting in valid playbooks being rejected. This patch mimics the old serialization logic in a tested and easy-to-debug way. Signed-off-by: mhorky <mhorky@redhat.com>
m-horky
force-pushed
the
cct-538/playbook-serialization-312
branch
from
dcae282
to
77381bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
The playbook verification relies signatures created from hashes of serialized snippets/playbooks. Python 3.12 changed the way it serializes OrderedDict objects into strings, making the verification fail, resulting in valid playbooks being rejected.
This patch mimics the old serialization logic in a tested and easy-to-debug way.