Test query host by ID #268
Conversation
There was a problem hiding this comment.
I believe some of these tests overlap with some tests in the QueryTestCase (test_query_using_host_id_list, test_query_using_host_id_list_include_nonexistent_host_ids, etc).
However, I like the approach of moving these tests into their own class. This makes the purpose of these tests more clear and should allow for easier splitting of these tests into their own files, etc later on.
Please remove the duplicated tests from QueryTestCase class and add the other host_id_list query related (tests test_query_using_host_id_list_one_host_id_does_not_include_hyphens) to this new class.
|
You’re right, @dehort! Some old tests are fully covered by the new ones, resulting in overlap:
Moved the missing host ID tests to the new class:
The host ID list tests are now together and so are the all hosts tests. Thanks! |
|
Aaaaargh, a conflict! |
The plain /hosts/{host_id_list} query has not had any tests yet. Added
some testing:
* Regular queries for a single and multiple hosts
* Queries with valid, but non-existent IDs
* Invalid queries
This complements the create hosts tests of UUID validation. Reused the
existing pagination tests.
The tests in QueryTestCase overlaps to some extent with new tests in QueryByHostIdTestCase. Removed those from QueryTestCase that are now completely redundant and moved those that test getting hosts by ID list to QueryByHostIdTestCase. Now, there are related tests in separate classes, entropy is lower.
Glutexo
force-pushed
the
query_by_host_id_tests
branch
from
97a8304
to
2724e2d
Compare
|
Resolved. 🎉 |
The plain /hosts/{host_id_list} query has not had any tests yet. Added some testing:
This complements the create hosts tests of UUID validation. Reused the existing pagination tests.
This is a part of fixes for #265. Related to #92.