Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed two outdated INGRESS_VALIDTOPICS entries #296

Merged
merged 1 commit into from
Dec 19, 2022
Merged

Removed two outdated INGRESS_VALIDTOPICS entries #296

merged 1 commit into from
Dec 19, 2022

Conversation

dscervantes
Copy link
Contributor

@dscervantes dscervantes commented Dec 19, 2022 •
edited

What?

Removed two Ingress Valid Topics, topological inventory and catalog
https://issues.redhat.com/browse/RHCLOUD-23449

Why?

INGRESS_VALIDTOPICS contains entries for defunct services: Topology and Catalog.

Secure Coding Practices Checklist Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

gmcculloug
gmcculloug approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@gmcculloug gmcculloug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dscervantes dscervantes changed the title modified: deploy/clowdapp.yaml Removed two outdated INGRESS_VALIDTOPICS entries Dec 19, 2022
@gmcculloug gmcculloug merged commit c17a9e4 into RedHatInsights:master Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmcculloug gmcculloug gmcculloug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dscervantes @gmcculloug