Add the role_external_tenant
param to the internal spec
#766
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were missing
role_external_tenant
in the internal API spec for the OCM integration. This will allow for clients to be built with and use this filter on nested roles for groups to filter by external tenant.Link(s) to Jira
Description of Intent of Change(s)
The /api/rbac/v1/integrations/tenant//groups//roles/ endpoint in the internal spec [1] needs to add support for the query param which allows roles to be filtered by external tenants.
We can use the same query param as is in the external spec [2] for "role_external_tenant".
[1] https://github.com/RedHatInsights/insights-rbac/blob/master/rbac/internal/specs/openapi.json#L304
[2]
insights-rbac/docs/source/specs/openapi.json
Lines 1396 to 1402 in cc2faa1
Local Testing
Generate a client and make use of
role_external_tenant
Checklist
Secure Coding Practices Checklist Link
Secure Coding Practices Checklist