Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let's not have any strange program logic in handlers #604

Merged
merged 1 commit into from Sep 9, 2021
Merged

Let's not have any strange program logic in handlers #604

merged 1 commit into from Sep 9, 2021

Conversation

tisnik
Copy link
Collaborator

@tisnik tisnik commented Sep 9, 2021

Description

Let's not have any strange program logic in handlers (the new function will be needed later, after all).

Type of change

  • Refactor (refactoring code, removing useless files)

Testing steps

N/A

Checklist

  • make before_commit passes
  • updated documentation wherever necessary
  • added or modified tests if necessary
  • updated schemas and validators in insights-data-schemas in case of input/output change

@tisnik tisnik merged commit ae759b6 into RedHatInsights:master Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpensi dpensi dpensi approved these changes

@epapbak epapbak epapbak approved these changes

@Bee-lee Bee-lee Awaiting requested review from Bee-lee Bee-lee is a code owner

@JiriPapousek JiriPapousek Awaiting requested review from JiriPapousek JiriPapousek is a code owner

@joselsegura joselsegura Awaiting requested review from joselsegura joselsegura is a code owner

@juandspy juandspy Awaiting requested review from juandspy juandspy is a code owner

@matysek matysek Awaiting requested review from matysek matysek is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tisnik @dpensi @epapbak