Disk device options

[Glutexo]

Added a constraint for /disk_devices/options. In Marshmallow we require all keys to be non-empty strings, including those of the nested objects. The new constraint does exactly this.

Examples of invalid payloads:

  "disk_devices": [
    {
      "type": "ext3",
      "label": "home drive",
      "device": "/dev/sdb1",
      "options": {
        "ro": true,
        "uid": "0",
        "": "thou shall not pass"
      },
      "mount_point": "/home"
    }
  ],

  "disk_devices": [
    {
      "type": "ext3",
      "label": "home drive",
      "device": "/dev/sdb1",
      "options": {
        "ro": true,
        "uid": "0",
        "nested": {
            "this": "is fine",
            "": "is not"
        }
      },
      "mount_point": "/home"
    }
  ],

[Glutexo]

Conquered the linter. There really was a missing description. Fixed.

[Glutexo]

In the end, the recursion introduced in this pull request caused a problem. prance is unfortunately unable to dereference the system profile schema if it contains recursion like this. The reason is that first the internal references in a referenced file are converted to file references and are no longer considered internal.

[Glutexo]

It actually makes perfect sense. It is not possible to keep the local references, because the references schemas are no longer locally available. It would be possible to insert them somewhere locally and then convert the local reference path. Prance however does not do this.

Created an issue for prance to ask the author what does he think about this. RonnyPfannschmidt/prance#77 We can’t however expect this to be resolved by the library. My suggestion is to ditch prance and dereference manually.