Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resize widget test #591

Merged
merged 7 commits into from
Jun 27, 2024
Merged

Add resize widget test #591

merged 7 commits into from
Jun 27, 2024

Conversation

InsaneZein
Copy link
Contributor

@InsaneZein InsaneZein commented Jun 4, 2024

Description

Adds a test for resizing widgets using the drag arrow in the corner
RHCLOUD-32153

Checklist ☑️

  • PR only fixes one issue or story
  • Change reviewed for extraneous code
  • UI best practices adhered to
  • Commits squashed and meaningfully named
  • All PR checks pass locally (build, lint, test, E2E)

  • (Optional) QE: Needs QE attention (OUIA changed, perceived impact to tests, no test coverage)
  • (Optional) QE: Has been mentioned
  • (Optional) UX: Needs UX attention (end user UX modified, missing designs)
  • (Optional) UX: Has been mentioned

@InsaneZein InsaneZein requested a review from a team June 4, 2024 15:04
@InsaneZein
Copy link
Contributor Author

/retest

@InsaneZein
Copy link
Contributor Author

test step is failing with this error message:

e2e test failed! Error: Command failed: NO_COLOR=1 E2E_USER=**** E2E_PASSWORD=**** npm run cypress run

@Hyperkid123
Copy link
Contributor

15:37:00   1) Widget Landing Page
15:37:00        Widget Layout
15:37:00          widgets can be resized:
15:37:00 
15:37:00       AssertionError: expected 'widget-columns-2' to be one of [ Array(6) ]
15:37:00       + expected - actual
15:37:00 
15:37:00       -'widget-columns-2'
15:37:00       +[ 'react-grid-item',
15:37:00       +  'widget-columns-1',
15:37:00       +  'widget-rows-4',
15:37:00       +  'react-draggable',
15:37:00       +  'cssTransforms',
15:37:00       +  'react-resizable' ]
15:37:00       
15:37:00       at Context.eval (webpack://landing-page-frontend/./cypress/e2e/widgets-landing.cy.ts:72:0)

This is the actual error.

});
// afterEach(() => {
// cy.resetToDefaultLayout();
// });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! If this part is no longer needed, we should probably delete it.

@InsaneZein
Copy link
Contributor Author

/retest

@karelhala karelhala merged commit 67ce55e into master Jun 27, 2024
4 checks passed
@InsaneZein InsaneZein deleted the resize-widget-test branch June 27, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants