Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHCLOUD-23629] Update Cost Management templates #1695

Conversation

g-duval
Copy link
Contributor

@g-duval g-duval commented Jan 18, 2023

image

image

image

image

image

image

image

Copy link
Member

@josejulio josejulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

I just have the nitpick about the variable being used only by tests

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2023

Codecov Report

Base: 60.70% // Head: 61.21% // Increases project coverage by +0.50% 🎉

Coverage data is based on head (121f5c4) compared to base (fc7f146).
Patch coverage: 98.24% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1695      +/-   ##
============================================
+ Coverage     60.70%   61.21%   +0.50%     
- Complexity     1256     1299      +43     
============================================
  Files           246      246              
  Lines          6200     6242      +42     
  Branches        597      597              
============================================
+ Hits           3764     3821      +57     
+ Misses         2222     2205      -17     
- Partials        214      216       +2     
Impacted Files Coverage Δ
.../notifications/templates/EmailTemplateFactory.java 43.90% <0.00%> (ø)
.../cloud/notifications/templates/CostManagement.java 89.06% <100.00%> (+89.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@josejulio josejulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@g-duval g-duval force-pushed the RHCLOUD-23629_updateCostManagementTemplaters branch from bec87e3 to 121f5c4 Compare January 23, 2023 13:31
@gwenneg gwenneg changed the title [RHCLOUD-23629] update cost management templaters [RHCLOUD-23629] update cost management templates Jan 23, 2023
@gwenneg gwenneg changed the title [RHCLOUD-23629] update cost management templates [RHCLOUD-23629] Update Cost Management templates Jan 23, 2023
@gwenneg gwenneg merged commit 42cf693 into RedHatInsights:master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants