-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHCLOUD-23629] Update Cost Management templates #1695
[RHCLOUD-23629] Update Cost Management templates #1695
Conversation
g-duval
commented
Jan 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
I just have the nitpick about the variable being used only by tests
engine/src/main/java/com/redhat/cloud/notifications/templates/TemplateService.java
Outdated
Show resolved
Hide resolved
Codecov ReportBase: 60.70% // Head: 61.21% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1695 +/- ##
============================================
+ Coverage 60.70% 61.21% +0.50%
- Complexity 1256 1299 +43
============================================
Files 246 246
Lines 6200 6242 +42
Branches 597 597
============================================
+ Hits 3764 3821 +57
+ Misses 2222 2205 -17
- Partials 214 216 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
bec87e3
to
121f5c4
Compare