Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHCLOUD-23788] Update Advisor email templates #1698

Conversation

g-duval
Copy link
Contributor

@g-duval g-duval commented Jan 19, 2023

image

image

image

image

image

@josejulio
Copy link
Member

I think we need to sync with UX regarding their templates.
We are expecting the emails to look like the after screenshots. I guess our UX and their UX need to talk about it.

According to ADVISOR-2022 their daily template looks as their design.
This might be a problem because I'm sure their weekly emails have the same look and feel.

@g-duval
Copy link
Contributor Author

g-duval commented Jan 19, 2023

Sure, I submitted the new version of our daily report to Shayna, she will rework it a little bit, then we will be able to compare our and their template to align them.
I tagged this PR as draft waiting new UXD input (I expect by tomorrow)

@g-duval g-duval marked this pull request as draft January 19, 2023 20:19
@g-duval g-duval force-pushed the RHCLOUD-23788_updateAdvisorEmailTemplates branch from 8e742b4 to 1d85040 Compare February 1, 2023 13:54
@codecov-commenter
Copy link

Codecov Report

Base: 61.43% // Head: 61.95% // Increases project coverage by +0.51% 🎉

Coverage data is based on head (1d85040) compared to base (3239147).
Patch coverage: 94.91% of modified lines in pull request are covered.

❗ Current head 1d85040 differs from pull request most recent head 1263d72. Consider uploading reports for the commit 1263d72 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1698      +/-   ##
============================================
+ Coverage     61.43%   61.95%   +0.51%     
- Complexity     1319     1355      +36     
============================================
  Files           247      247              
  Lines          6273     6314      +41     
  Branches        593      594       +1     
============================================
+ Hits           3854     3912      +58     
+ Misses         2205     2179      -26     
- Partials        214      223       +9     
Impacted Files Coverage Δ
...cloud/notifications/templates/TemplateService.java 92.50% <ø> (ø)
...loud/notifications/templates/AdvisorOpenshift.java 55.55% <72.72%> (+47.22%) ⬆️
...sors/email/aggregators/AdvisorEmailAggregator.java 94.23% <100.00%> (+1.54%) ⬆️
.../redhat/cloud/notifications/templates/Advisor.java 81.13% <100.00%> (+63.89%) ⬆️
.../notifications/templates/EmailTemplateFactory.java 43.90% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@g-duval g-duval marked this pull request as ready for review February 1, 2023 14:16
@g-duval g-duval force-pushed the RHCLOUD-23788_updateAdvisorEmailTemplates branch 2 times, most recently from 785e10d to c2f731b Compare February 3, 2023 16:06
@gwenneg gwenneg self-assigned this Feb 7, 2023
@g-duval g-duval force-pushed the RHCLOUD-23788_updateAdvisorEmailTemplates branch 4 times, most recently from 9a47e71 to 93fa139 Compare February 7, 2023 21:43
@gwenneg gwenneg changed the title [RHCLOUD-23778] Update Advisor templates [RHCLOUD-23778] Update Advisor email templates Feb 10, 2023
@g-duval g-duval changed the title [RHCLOUD-23778] Update Advisor email templates [RHCLOUD-23788] Update Advisor email templates Feb 10, 2023
@gwenneg
Copy link
Member

gwenneg commented Feb 13, 2023

@g-duval Could you please rebase this PR?

@gwenneg gwenneg force-pushed the RHCLOUD-23788_updateAdvisorEmailTemplates branch from 63ff55c to 31a45a5 Compare February 13, 2023 16:17
Copy link
Member

@gwenneg gwenneg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gwenneg
Copy link
Member

gwenneg commented Feb 13, 2023

The PR check failure is unrelated.

@gwenneg gwenneg merged commit 4df3b81 into RedHatInsights:master Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants