-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHCLOUD-23788] Update Advisor email templates #1698
[RHCLOUD-23788] Update Advisor email templates #1698
Conversation
g-duval
commented
Jan 19, 2023
•
edited
edited
I think we need to sync with UX regarding their templates. According to ADVISOR-2022 their daily template looks as their design. |
Sure, I submitted the new version of our daily report to Shayna, she will rework it a little bit, then we will be able to compare our and their template to align them. |
8e742b4
to
1d85040
Compare
Codecov ReportBase: 61.43% // Head: 61.95% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1698 +/- ##
============================================
+ Coverage 61.43% 61.95% +0.51%
- Complexity 1319 1355 +36
============================================
Files 247 247
Lines 6273 6314 +41
Branches 593 594 +1
============================================
+ Hits 3854 3912 +58
+ Misses 2205 2179 -26
- Partials 214 223 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
785e10d
to
c2f731b
Compare
common/src/main/java/com/redhat/cloud/notifications/config/FeatureFlipper.java
Show resolved
Hide resolved
9a47e71
to
93fa139
Compare
...java/com/redhat/cloud/notifications/processors/email/aggregators/AdvisorEmailAggregator.java
Show resolved
Hide resolved
engine/src/main/resources/templates/Advisor/deactivatedRecommendationInstantEmailBodyV2.html
Outdated
Show resolved
Hide resolved
@g-duval Could you please rebase this PR? |
…tureFlipper.java Co-authored-by: Gwenneg Lepage <gwenneg@users.noreply.github.com>
63ff55c
to
31a45a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The PR check failure is unrelated. |