Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHCLOUD-23855] update drift email templates #1701

Merged

Conversation

g-duval
Copy link
Contributor

@g-duval g-duval commented Jan 20, 2023

image

image

Copy link
Member

@josejulio josejulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
needs rebasing

@gwenneg gwenneg force-pushed the RHCLOUD-23855_updateDriftEmailTemplates branch from 23f7a43 to 8658e5b Compare February 2, 2023 08:54
@gwenneg
Copy link
Member

gwenneg commented Feb 2, 2023

Fixed conflicts.

@codecov-commenter
Copy link

Codecov Report

Base: 61.60% // Head: 61.77% // Increases project coverage by +0.16% 🎉

Coverage data is based on head (8658e5b) compared to base (dad98cf).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1701      +/-   ##
============================================
+ Coverage     61.60%   61.77%   +0.16%     
- Complexity     1331     1343      +12     
============================================
  Files           247      247              
  Lines          6285     6297      +12     
  Branches        593      593              
============================================
+ Hits           3872     3890      +18     
+ Misses         2199     2193       -6     
  Partials        214      214              
Impacted Files Coverage Δ
...om/redhat/cloud/notifications/templates/Drift.java 86.36% <100.00%> (+76.36%) ⬆️
.../notifications/templates/EmailTemplateFactory.java 43.90% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gwenneg gwenneg merged commit eef1769 into RedHatInsights:master Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants