[RHCLOUD-23947] update Edge Management templates according UXD #1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
g-duval
commented
Jan 25, 2023
g-duval
commented
Codecov ReportBase: 62.15% // Head: 62.33% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1716 +/- ##
============================================
+ Coverage 62.15% 62.33% +0.18%
- Complexity 1374 1387 +13
============================================
Files 247 247
Lines 6328 6340 +12
Branches 594 594
============================================
+ Hits 3933 3952 +19
+ Misses 2172 2163 -9
- Partials 223 225 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
g-duval
force-pushed
the
RHCLOUD-23947_updateEdgeManagementTemplates
branch
from
0b18a81
to
3001d19
Compare
g-duval
force-pushed
the
RHCLOUD-23947_updateEdgeManagementTemplates
branch
from
11371fd
to
8f008b5
Compare
|
PR check failures are unrelated. |
ldjebran
added a commit
to ldjebran/edge-api
that referenced
this pull request
Feb 28, 2023
FIXES: THEEDGE-3149 The email notification was sent with empty device name, see issue comment. - Move send notification call to later stage when the update transaction model will have all the necessary data (already unittest covered). - Fixes the notification payload to have update transaction device name, as it's expected by notifications-backend service RedHatInsights/notifications-backend#1716 (added unittest for the changes).
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.