Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHCLOUD-23958] update Resource Optimization template according UXD #1722

Conversation

g-duval
Copy link
Contributor

@g-duval g-duval commented Jan 26, 2023

image

@@ -186,6 +190,7 @@ public boolean isComplianceEmailTemplatesV2Enabled() {
}

public void setComplianceEmailTemplatesV2Enabled(boolean complianceEmailTemplatesV2Enabled) {
checkTestLaunchMode();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add test check on already merged template updates

@g-duval g-duval force-pushed the RHCLOUD-23958_updateResourceOptimizationEmailTemplate branch from 63a82e8 to 7843741 Compare February 3, 2023 11:19
@gwenneg gwenneg self-assigned this Feb 3, 2023
Copy link
Member

@gwenneg gwenneg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gwenneg
Copy link
Member

gwenneg commented Feb 3, 2023

PR check failures are unrelated.

@gwenneg gwenneg merged commit 8617f05 into RedHatInsights:master Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants