Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHCLOUD-24100 update Vulnerability's templates #1735

Conversation

g-duval
Copy link
Contributor

@g-duval g-duval commented Feb 2, 2023

image

image

image

image

image

@g-duval g-duval force-pushed the RHCLOUD-24100_updateVulnerabilityEmailTemplates branch from 5a5acde to 5c73dc1 Compare February 3, 2023 12:59
@gwenneg gwenneg self-assigned this Feb 3, 2023
Copy link
Member

@gwenneg gwenneg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2023

Codecov Report

Base: 62.41% // Head: 62.89% // Increases project coverage by +0.47% 🎉

Coverage data is based on head (6a7fd96) compared to base (8617f05).
Patch coverage: 86.79% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1735      +/-   ##
============================================
+ Coverage     62.41%   62.89%   +0.47%     
- Complexity     1394     1425      +31     
============================================
  Files           247      247              
  Lines          6346     6376      +30     
  Branches        594      594              
============================================
+ Hits           3961     4010      +49     
+ Misses         2160     2137      -23     
- Partials        225      229       +4     
Impacted Files Coverage Δ
.../notifications/templates/EmailTemplateFactory.java 43.90% <0.00%> (ø)
...t/cloud/notifications/templates/Vulnerability.java 79.03% <88.46%> (+79.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gwenneg
Copy link
Member

gwenneg commented Feb 3, 2023

PR check failures are unrelated.

@gwenneg gwenneg merged commit 86a707e into RedHatInsights:master Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants