[RHCLOUD-24200] Update AdvisorOpenshift email template #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
g-duval
commented
Feb 7, 2023
g-duval
commented
g-duval
force-pushed
the
RHCLOUD-24200_updateAnsibleOpenShiftEmailTemplates
branch
2 times, most recently
from
3ab7a58
to
5806ce2
Compare
|
Could you please fix the commit message and PR title? This is about Advisor and not Ansible 😃 |
gwenneg
reviewed
Feb 10, 2023
common/src/main/java/com/redhat/cloud/notifications/config/FeatureFlipper.java
Show resolved
Hide resolved
engine/src/test/java/com/redhat/cloud/notifications/templates/TestAdvisorOpenShiftTemplate.java
Outdated
Show resolved
Hide resolved
engine/src/test/java/com/redhat/cloud/notifications/templates/TestAdvisorOpenShiftTemplate.java
Outdated
Show resolved
Hide resolved
gwenneg
changed the title
gwenneg
force-pushed
the
RHCLOUD-24200_updateAnsibleOpenShiftEmailTemplates
branch
from
bb49d49
to
c3de1b3
Compare
|
I removed all traces of "Ansible" in the commit and PR titles. |
|
/retest |
1 similar comment
|
/retest |
gwenneg
force-pushed
the
RHCLOUD-24200_updateAnsibleOpenShiftEmailTemplates
branch
from
c3de1b3
to
8787449
Compare
|
/retest |
1 similar comment
|
/retest |
|
The Quarkus downgrade didn't help, I need to revert that commit |
gwenneg
force-pushed
the
RHCLOUD-24200_updateAnsibleOpenShiftEmailTemplates
branch
from
0b25c1c
to
52582c3
Compare
gwenneg
force-pushed
the
RHCLOUD-24200_updateAnsibleOpenShiftEmailTemplates
branch
from
52582c3
to
59f8866
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.