Check for available EngId before using arch

RedHatInsights · Oct 16, 2023 · f4ae1d9 · f4ae1d9
1 parent 5e942d6
commit f4ae1d9
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/main/java/org/candlepin/subscriptions/tally/facts/FactNormalizer.java b/src/main/java/org/candlepin/subscriptions/tally/facts/FactNormalizer.java
@@ -26,6 +26,7 @@
 import java.util.Collection;
 import java.util.Objects;
 import java.util.stream.Collectors;
+import org.apache.commons.collections4.CollectionUtils;
 import org.candlepin.subscriptions.ApplicationProperties;
 import org.candlepin.subscriptions.db.model.HardwareMeasurementType;
 import org.candlepin.subscriptions.db.model.HostHardwareType;
@@ -329,7 +330,8 @@ private void handleSla(
   private void normalizeQpcFacts(NormalizedFacts normalizedFacts, InventoryHostFacts hostFacts) {
     // Check if this is a RHEL host and set product.
     if (hostFacts.getQpcProducts() != null && hostFacts.getQpcProducts().contains("RHEL")) {
-      if (hostFacts.getSystemProfileArch() != null) {
+      if (hostFacts.getSystemProfileArch() != null
+          && CollectionUtils.isEmpty(hostFacts.getQpcProductIds())) {
         switch (hostFacts.getSystemProfileArch()) {
           case "x86_64", "i686", "i386":
             normalizedFacts.addProduct("RHEL for x86");

diff --git a/src/test/java/org/candlepin/subscriptions/tally/facts/FactNormalizerTest.java b/src/test/java/org/candlepin/subscriptions/tally/facts/FactNormalizerTest.java
@@ -686,6 +686,14 @@ void testQpcSystemArchSetRhelForIbmPower() {
     assertThat(normalized.getProducts(), Matchers.hasItem("RHEL for IBM Power"));
   }
 
+  @Test
+  void testQpcProductIdFromEngId() {
+    var host = createQpcHost("RHEL", "Test", clock.now());
+    host.setQpcProductIds("69");
+    NormalizedFacts normalized = normalizer.normalize(host, hypervisorData());
+    assertThat(normalized.getProducts(), Matchers.hasItem("RHEL for x86"));
+  }
+
   private void assertClassification(
       NormalizedFacts check, boolean isHypervisor, boolean isHypervisorUnknown, boolean isVirtual) {
     assertEquals(isHypervisor, check.isHypervisor());