Fix incorrect liquibase references to instance_id #1286
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confusingly, we have a column named
instance_id
on thehosts
table;we also have a column named
instance_id
oninstance_measurements
.However, the
instance_id
oninstance_measurements
referenceshosts.id
and NOThosts.instance_id
.Testing
Try the following sql for testing the trigger change:
The original testing instructions used the same value for both
id
andinstance_id
, which is possibly why this wasn't caught sooner.Note that given the changesets involved were modified, I added
runOnChange=true
to simplify re-running against deployments where it'salready run.