SWATCH-1613: Fully drop uom column from instance measurements table #2471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awood
approved these changes
Sep 1, 2023
| @@ -122,8 +122,7 @@ | |||
| <!-- <include file="liquibase/202308211518-rename-rhel-product-ids.xml"/> --> | |||
| <include file="liquibase/202307261851-event-change-event-type-data.xml"/> | |||
| <include file="liquibase/202308210806-add-metric-id-instance-measurements.xml"/> | |||
| <!-- Uncomment once the above changeset has landed in prod --> | |||
| <!-- <include file="liquibase/202308210906-drop-uom-column-instance-measurements.xml"/> --> | |||
| <include file="liquibase/202308210906-drop-uom-column-instance-measurements.xml"/> | |||
| <include file="liquibase/202308231356-add-metric-id-tally-measurements.xml"/> | |||
| <!-- Uncomment once the above changeset has landed in prod --> | |||
| <!-- <include file="liquibase/202308231456-drop-uom-column-tally-measurements.xml"/> --> | |||
There was a problem hiding this comment.
Do we have card for dropping the column off tally_measurements as well? I did a search on the backlog but didn't see anything. If not, should we roll dropping uom on tally_measurements into this?
There was a problem hiding this comment.
Yes, I created this ticket https://issues.redhat.com/browse/SWATCH-1657 for dropping uom from tally_measurements which we can't do yet because https://issues.redhat.com/browse/SWATCH-430 is not released yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue: SWATCH-1613
Description
After https://issues.redhat.com/browse/SWATCH-371 is released, we need to fully drop the uom column from the instance measurements.
Testing
1.- Run the migration using:
./gradlew :liquibaseUpdate. The columnuomshould have been dropped from the tablesinstance_measurementsandinstance_monthly_totals.2.- Test the rollback by calling twice:
./gradlew :liquibaseRollbackCount -PliquibaseCommandValue=2. The columnuomshould have been back to the tablesinstance_measurementsandinstance_monthly_totals.