swatch-661: System Conduit replace AccountConfigRepository with OrgConfigRepository #2632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbusch
force-pushed
the
vbusch/swatch-661-remove-account-number-from-system-conduit
branch
2 times, most recently
from
c2f5e3a
to
8abbbb8
Compare
|
/retest |
vbusch
force-pushed
the
vbusch/swatch-661-remove-account-number-from-system-conduit
branch
2 times, most recently
from
f52f798
to
0c2cacd
Compare
kflahert
approved these changes
Oct 12, 2023
…in system conduit Signed-off-by: vbusch <vbusch@redhat.com>
vbusch
force-pushed
the
vbusch/swatch-661-remove-account-number-from-system-conduit
branch
from
0c2cacd
to
8e07831
Compare
vbusch
deleted the
vbusch/swatch-661-remove-account-number-from-system-conduit
branch
Sgitario
added a commit
that referenced
this pull request
Feb 19, 2024
The inventory hosts `account` property was dropped in #2632, in favour of the `orgId` property. However, some third party systems like the Config Manager (see [here](https://github.com/RedHatInsights/config-manager/blob/518725892e4e560cd1add593393e8a0c0787c1f5/internal/host.go#L95)) still requires it. Therefore, let's populate the `account` field (even when we don't use it), so third party systems can keep working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue: SWATCH-661
Description
Testing
Unit tests & Regression