New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SWATCH-2021: Report filtered subscription data to Export Service in JSON #3171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sgitario
added
QE
Pull request should be approved by QE before merge
Dev
Pull requests that need developer review
labels
Mar 21, 2024
/retest |
Sgitario
force-pushed
the
jcarvaja/SWATCH-2021
branch
4 times, most recently
from
March 22, 2024 12:56
d654476
to
76ada2f
Compare
Sgitario
force-pushed
the
jcarvaja/SWATCH-2021
branch
from
March 25, 2024 11:33
76ada2f
to
c5f58e5
Compare
lindseyburnett
approved these changes
Mar 25, 2024
lindseyburnett
added
Dev/approved
Pull requests that have been approved by all assigned developers
and removed
Dev
Pull requests that need developer review
labels
Mar 25, 2024
/retest |
san7ket
added
QE/approved
Pull requests that have been approved by all assigned QEs
and removed
QE
Pull request should be approved by QE before merge
labels
Mar 27, 2024
/retest |
1 similar comment
/retest |
san7ket
added
QE
Pull request should be approved by QE before merge
and removed
QE/approved
Pull requests that have been approved by all assigned QEs
labels
Mar 28, 2024
@Sgitario In failed tests, I am seeing increase in time , for export request to be completed, with approx 220+ subs in account. What would be the expected wait_time here? |
/retest |
Sgitario
force-pushed
the
jcarvaja/SWATCH-2021
branch
from
April 2, 2024 06:14
c5f58e5
to
c6c445a
Compare
/retest |
Sgitario
force-pushed
the
jcarvaja/SWATCH-2021
branch
3 times, most recently
from
April 2, 2024 09:01
20acc70
to
390f46f
Compare
Added support of JSON uploads via export service. I could verified e2e the integration with a real export-service, and I could spot that we were using the UUIDs wrongly, the ID was the Export Request UUID and the resource ID was the UUID.
Sgitario
force-pushed
the
jcarvaja/SWATCH-2021
branch
from
April 2, 2024 09:47
390f46f
to
4f59866
Compare
san7ket
added
QE/approved
Pull requests that have been approved by all assigned QEs
and removed
QE
Pull request should be approved by QE before merge
labels
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Dev/approved
Pull requests that have been approved by all assigned developers
QE/approved
Pull requests that have been approved by all assigned QEs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue: SWATCH-2021
Description
Added support of JSON uploads via export service.
I could verified e2e the integration with a real export-service, and I could spot that we were using the UUIDs wrongly, the ID was the Export Request UUID and the resource ID was the UUID.
Testing
1.- start kafka and postgresql:
podman-compose up -d
2.- start export-service:
podman-compose -f config/export-service/docker-compose.yml up -d
3.- start subscription sync service:
DEV_MODE=true SPRING_PROFILES_ACTIVE="capacity-ingress,api,kafka-queue" ./gradlew :bootRun
4.- load some data:
5.- create a new export request from Export Service:
get the identifier first:
call the export service:
Expected output is:
6.- verification:
check the subscription sync logs where you should see the new event coming from the Export service topic:
The export-service should have uploaded the generated report by the subscription sync service into S3 (minio instance).
You can verify that this report has been uploaded by checking the folder 'config/export-service/tmp/minio/exports-bucket' where should be a file at
<BUCKET ID>.json/xl.meta
. Thexl.meta
file is binary, but if you open the txt plain editor, you should see:7.- verify wrong filters:
let's try to use a wrong value for product ID:
Then, you should see the following traces in the the subscription sync logs:
And in the export-service database (by default, it's: "localhost:5342", user: postgres, password: postgres, database name: postgres), you can see a new record in the table "sources" with: