-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SWATCH-2356: Send request to enabled-orgs-for-tasks for prune and sync #3277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sgitario
added
QE
Pull request should be approved by QE before merge
Dev
Pull requests that need developer review
labels
Apr 22, 2024
Sgitario
force-pushed
the
jcarvaja/SWATCH-2356
branch
from
April 22, 2024 14:01
1bee01c
to
996987a
Compare
Sgitario
force-pushed
the
jcarvaja/SWATCH-2356
branch
from
April 22, 2024 19:12
996987a
to
a6eb075
Compare
/retest |
/retest |
1 similar comment
/retest |
Steps are performing as described. Looking into few things in code. |
Sgitario
force-pushed
the
jcarvaja/SWATCH-2356
branch
2 times, most recently
from
April 25, 2024 07:18
0eb8917
to
9e17267
Compare
Verification steps:
Looks good to me |
https://gitlab.cee.redhat.com/insights-qe/iqe-rhsm-subscriptions-plugin/-/merge_requests/669 raised to fix the failed contract api tests |
Aurobinda55
approved these changes
Apr 25, 2024
ntkathole
added
QE/approved
Pull requests that have been approved by all assigned QEs
and removed
QE
Pull request should be approved by QE before merge
labels
Apr 30, 2024
kartikshahc
approved these changes
May 1, 2024
kartikshahc
added
Dev/approved
Pull requests that have been approved by all assigned developers
and removed
Dev
Pull requests that need developer review
labels
May 1, 2024
- The method "pruneUnlistedSubscriptions" from SWATCH-2277 should produce a single message to "platform.rhsm-subscriptions.enabled-orgs-for-tasks" with a message containing the topic name "platform.rhsm-subscriptions.subscription-prune-task". - The method "syncAllSubscriptions" from SWATCH-2277 should produce a single message to "platform.rhsm-subscriptions.enabled-orgs-for-tasks" with a message containing the topic name "platform.rhsm-subscriptions.subscription-sync-task". - Create the consumer of "platform.rhsm-subscriptions.subscription-prune-task" that receives a message that includes the orgId. Leave the implementation empty. - Create the consumer of "platform.rhsm-subscriptions.subscription-sync-task" that receives a message that includes the orgId. Leave the implementation empty.
Sgitario
force-pushed
the
jcarvaja/SWATCH-2356
branch
from
May 2, 2024 04:53
9e17267
to
40e180f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Dev/approved
Pull requests that have been approved by all assigned developers
QE/approved
Pull requests that have been approved by all assigned QEs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue: SWATCH-2356
Description
Testing
1.- podman-compose up
2.- start tally:
3.- populate some enabled orgs:
4.- start contracts service:
5.- start subscriptions prune task:
Verification: you should see the following traces in the contracts service:
6.- start subscriptions sync task:
Verification: you should see the following traces in the contracts service: