This repository has been archived by the owner on Jan 8, 2022. It is now read-only.
Saving updated tasks to IC #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
slemrmartin
force-pushed
the
task-update-kafka
branch
from
58d2ea9
to
73f4993
Compare
slemrmartin
changed the title
slemrmartin
commented
Apr 28, 2020
slemrmartin
force-pushed
the
task-update-kafka
branch
from
73f4993
to
2fdfced
Compare
agrare
reviewed
Apr 28, 2020
|
|
||
| # 2) Saving to updated records (will be published in Kafka) | ||
| # - see topological_inventory-persister:Workflow.send_task_updates_to_queue! | ||
| tasks_collection.updated_records << values.merge(:id => task.id, :request_id => task.x_rh_insights_request) |
There was a problem hiding this comment.
request_id => task.x_rh_insights_request
Should the key that we're setting here match the column name?
slemrmartin
force-pushed
the
task-update-kafka
branch
from
2fdfced
to
9aa6541
Compare
agrare
approved these changes
Apr 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue RedHatInsights/topological_inventory-ansible_tower#83
Updated tasks are saved to inventory collections for further processing by Persister's Workflow.
dependent RedHatInsights/topological_inventory-persister#56
Gem version: 1.1.2